This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
fix(createInstantSearch): remove the client from the Snapshot #749
+11
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview ready! Built with commit 9b633b6 |
Haroenv
approved these changes
Dec 20, 2017
| "addAlgoliaAgent": [MockFunction] { | ||
| "calls": Array [ | ||
| Array [ | ||
| "react-instantsearch 4.3.0-beta.0", |
There was a problem hiding this comment.
yep, makes sense to not have the version number in the tests
samouss
force-pushed
the
fix/snapshot-with-version
branch
from
094720e to
9b633b6
Compare
samouss
added a commit
that referenced
this pull request
Jan 3, 2018
<a name="4.4.0"></a> * **createInstantSearch:** remove the client from the Snapshot ([#749](#749)) ([700d8f4](700d8f4)) * refresh cache memory leak example ([#784](#784)) ([cf228ac](cf228ac)) * **stories:** rename InstantSearch to <InstantSearch> ([#789](#789)) ([05efda5](05efda5)) * InstantSearch root props ([#770](#770)) ([2d458f8](2d458f8))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With
jest@22the mock function are now print with the snapshot.So when we call
createInstantSearchfrom the test, we provide a mock client with the current version of the lib. We already test that the instance is called with the correct client (see below). So we don't need to print the client mock in the snapshot. It will avoid that every time we release a new version we have to fix the snapshot, just because the version bump.